chore: update native-abort-controller #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid extending built-in classes you now need to use named exports when importing `native-abort-controller`.
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 3, 2021
To avoid Fixes #3509 Depends on: - [ ] ipfs/js-ipfs-utils#93
2 tasks
hugomrdias
approved these changes
Feb 3, 2021
achingbrain
added a commit
that referenced
this pull request
Feb 3, 2021
Similar to #93, updates `native-fetch` and removes vendored filed. I get a TS error when trying to generate types though, might have to wait until TS 4.2: ``` > [email protected] prepare /Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils > aegir build --no-bundle /Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:87003 throw e; ^ TypeError: Cannot read property 'kind' of undefined at getRootDeclaration (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:12609:21) at Object.isCatchClauseVariableDeclarationOrBindingElement (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:10439:20) at getTypeOfVariableOrParameterOrPropertyWorker (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:41796:20) at getTypeOfVariableOrParameterOrProperty (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:41775:28) at getTypeOfSymbol (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:42079:24) at getTypeOfAlias (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:42025:23) at getTypeOfSymbol (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:42091:24) at checkIdentifier (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:53527:49) at checkExpressionWorker (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:59973:28) at checkExpression (/Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/node_modules/typescript/lib/tsc.js:59928:38) Command failed with exit code 1: tsc --build /Users/alex/Documents/Workspaces/ipfs/js-ipfs-utils/tsconfig-types.aegir.json ```
achingbrain
added a commit
that referenced
this pull request
Feb 3, 2021
Similar to #93, updates `native-fetch` and removes vendored types. I had to remove the exported `ResponseWithURL` class from `src/http/fetch.browser.js` otherwise it caused generating types to fail with `TypeError: Cannot read property 'kind' of undefined`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid extending built-in classes you now need to use named exports when importing
native-abort-controller.