This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
refactor: export types and utilities statically #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
approved these changes
Mar 6, 2019
added 2 commits
March 6, 2019 11:38
Allows users to access these additional types and utilities without having to create an instance first.
BREAKING CHANGE: `ipfs.util.isIPFS` and `ipfs.util.crypto` have moved to static exports and should be accessed via `const { isIPFS, crypto } = require('ipfs')`.
The modules available under `ipfs.types.*` have also become static exports.
License: MIT
Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
force-pushed
the
refactor/static-exports
branch
from
706c8af to
cdbeed7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to access these additional types and utilities without having to create an instance first.
BREAKING CHANGE:
ipfs.util.isIPFSandipfs.util.cryptohave moved to static exports and should be accessed viaconst { isIPFS, crypto } = require('ipfs').The modules available under
ipfs.types.*have also become static exports.refs ipfs-inactive/js-ipfs-http-client#902
refs ipfs-inactive/js-ipfs-http-client#951