feat: add support for ipns name resolve /ipns/<fqdn> #2002

hugomrdias · 2019-04-18T15:57:11Z

fixes: #1918

needs:

lidel

I am afraid the default behavior of go-ipfs changed since we discussed this last time:
https://blog.ipfs.io/83-go-ipfs-0-4-20/#changed-ipfs-resolve-ipfs-dns-ipfs-name-resolve

I believe we should switch behavior in this PR to be recursive by default, to align with go-ipfs 0.4.20 while we are at it.

Below is a summary of edge cases (:anger: indicates discrepancy on our end) when we have more than one level of dnslink (eg. ipfs.io → website.ipfs.io → /ipfs/)

raw hostnames

name resolve ipfs.io (recursive by default)
- go-ipfs 0.4.20: /ipfs/QmeA4pdfRMq1ABThuTYTRgHzCu8xthuoUeK6DsRMMqj33b
- this PR: /ipns/website.ipfs.io 💢
name resolve ipfs.io --recursive=true
- go-ipfs 0.4.20: /ipfs/QmeA4pdfRMq1ABThuTYTRgHzCu8xthuoUeK6DsRMMqj33b
- this PR: /ipns/website.ipfs.io 💢
name resolve ipfs.io --recursive=false
- go-ipfs 0.4.20: /ipns/website.ipfs.io
- this PR: /ipns/website.ipfs.io

IPNS paths

name resolve /ipns/ipfs.io/images/ipfs-logo.svg (recursive by default)
- go-ipfs 0.4.20: /ipfs/QmeA4pdfRMq1ABThuTYTRgHzCu8xthuoUeK6DsRMMqj33b/images/ipfs-logo.svg
- this PR: /ipns/website.ipfs.io 💢
name resolve /ipns/ipfs.io/images/ipfs-logo.svg --recursive=true
- go-ipfs 0.4.20: /ipfs/QmeA4pdfRMq1ABThuTYTRgHzCu8xthuoUeK6DsRMMqj33b/images/ipfs-logo.svg
- this PR: /ipns/website.ipfs.io 💢
name resolve /ipns/ipfs.io/images/ipfs-logo.svg --recursive=false
- go-ipfs 0.4.20: /ipns/website.ipfs.io/images/ipfs-logo.svg
- this PR: /ipns/website.ipfs.io 💢

hugomrdias · 2019-04-22T18:20:23Z

We can't right now I already opened an issue about it (#2001), it breaks name pubsub. I want to merge this and then fix that.

lidel · 2019-04-22T20:47:37Z

@hugomrdias ack on not making it recursive by default in this PR, but unless I am missing some context, name resolve with explicit --recursive=true and --recursive=false should still produce the same result as in go-ipfs, but it does not right now (examples in #2002 (review))

hugomrdias · 2019-05-06T10:33:30Z

@lidel i can only reproduce this one

name resolve /ipns/ipfs.io/images/ipfs-logo.svg --recursive=false

go-ipfs 0.4.20: /ipns/website.ipfs.io/images/ipfs-logo.svg
this PR: /ipns/website.ipfs.io 💢

all the others work as go does.

lidel

@hugomrdias I retested after rebase and you are right, that is the only discrepancy left (apart from switching the default, which is tracked in #2001)

It requires below to PRs to land first: #2002 ipfs/js-ipfs-http-response#19 ipfs-inactive/js-ipfs-mfs#48 License: MIT Signed-off-by: Marcin Rataj <[email protected]>

It requires below to PRs to land first: ipfs#2002 ipfs/js-ipfs-http-response#19 ipfs-inactive/js-ipfs-mfs#48 License: MIT Signed-off-by: Marcin Rataj <[email protected]>

alanshaw · 2019-05-08T08:36:13Z

@hugomrdias does this supercede #1970?

tl;dr opening /ipns/tr.wikipedia-on-ipfs.org/wiki/Mars.html works Switched to js-ipfs with cherry-picked changes from: ipfs/js-ipfs#2020 ipfs/js-ipfs#1989 ipfs/js-ipfs#2002 ipfs/js-ipfs-http-response#22 ipfs-inactive/js-ipfs-mfs#48

hugomrdias · 2019-05-08T19:48:17Z

@hugomrdias does this supercede #1970?

yes for ipfs name resolve, i will handle ipfs resolve in another PR

It requires below to PRs to land first: #2002 ipfs/js-ipfs-http-response#19 ipfs-inactive/js-ipfs-mfs#48 License: MIT Signed-off-by: Marcin Rataj <[email protected]>

fixes: #1918

`ipns name resolve` dns tests moved to interface-core resolve call now return a string as per documention

enables ipns tests in the browser normalizes interface tests over core with interface tests over http-client using http api

alanshaw

Many tests have been removed?

package.json

src/utils/tlru.js

alanshaw · 2019-06-20T10:56:05Z

test/cli/name-pubsub.js

-            expect(res).to.satisfy(checkAll([cidAdded])) // value propagated to node B
-          })
-      })
-    })


What's the reason for this test being removed?

core has tests that do mostly the same thing, i discussed this with vasco and we decided to remove this.

hugomrdias · 2019-06-21T11:10:00Z

Many tests have been removed?

has we already discussed this PR tries to keep all tests in interface-core or core and cli tests only test cli behaviour.

alanshaw · 2019-06-23T08:00:33Z

as we already discussed this PR tries to keep all tests in interface-core or core and cli tests only test cli behaviour.

I think that’s the right way, but we need to make sure we have the same coverage as we did before (and preferably more)

alanshaw · 2019-06-24T09:25:29Z

Can we please fix this coverage:

https://codecov.io/gh/ipfs/js-ipfs/compare/88f4e264ee14986c2b2eb16263f747631ef58958...0c833c30fd95125820feab1921a918213d3004bf/changes

alanshaw

I believe the coverage drop is false and because of this issue #2202

It requires below to PRs to land first: #2002 ipfs/js-ipfs-http-response#19 ipfs-inactive/js-ipfs-mfs#48 License: MIT Signed-off-by: Marcin Rataj <[email protected]>

> Part of an effort to run embedded js-ipfs in Brave 🦁 ipfs/ipfs-companion#716 > Fixes #1918 This PR will add support for `/ipns/` paths at HTTP Gateway. Smoke test: [/ipns/tr.wikipedia-on-ipfs.org](http://127.0.0.1:9090/ipns/tr.wikipedia-on-ipfs.org/wiki/Anasayfa.html) (IPNS+DNSLink+HAMT-sharded website) This PR depends on the following merged PRs: - Gateway Improvements from #1989 (after merging #1989 I will rebase this PR, which will remove first two commits) - PeerID eg. `/ipns/<PeerId-as-multihash-b58>` - requires #2002 to land first - `/ipns/<libp2p-key-in-cidv1>` - requires multiformats/js-multicodec#45 - DNSLink eg. `/ipns/<fqdn>/path/file` like `/ipns/docs.ipfs.io/assets/logo.svg` - requires #2002 to land first - HAMT shard support eg. `/ipns/tr.wikipedia-on-ipfs.org/wiki/Anasayfa.html` (`wiki` is a sharded directory) - requires ipfs/js-ipfs-http-response#22 and ipfs-inactive/js-ipfs-mfs#48 to land first - Tests for `/ipns/` License: MIT Signed-off-by: Marcin Rataj <[email protected]>

hugomrdias requested review from alanshaw and lidel April 18, 2019 15:57

ghost assigned hugomrdias Apr 18, 2019

ghost added the status/in-progress In progress label Apr 18, 2019

hugomrdias mentioned this pull request Apr 18, 2019

IPNS over DNS #2000

Closed

15 tasks

lidel mentioned this pull request Apr 22, 2019

feat: add support to resolve dns to ipns ipfs-inactive/interface-js-ipfs-core#458

Merged

lidel suggested changes Apr 22, 2019

View reviewed changes

hugomrdias force-pushed the feat/name-resolve-dns branch from 314c70a to 4b70dc6 Compare May 6, 2019 09:46

lidel reviewed May 6, 2019

View reviewed changes

lidel mentioned this pull request May 6, 2019

Sharding support in /ipns/<fqdn> paths ipfs/js-ipfs-http-response#22

Open

lidel added a commit that referenced this pull request May 7, 2019

feat: support /ipns/ at HTTP Gateway

571eb4b

It requires below to PRs to land first: #2002 ipfs/js-ipfs-http-response#19 ipfs-inactive/js-ipfs-mfs#48 License: MIT Signed-off-by: Marcin Rataj <[email protected]>

lidel mentioned this pull request May 7, 2019

feat: add HTTP Gateway support for /ipns/ paths #2020

Merged

6 tasks

lidel mentioned this pull request May 8, 2019

feat(brave): Embedded HTTP Gateway for /ipns/{fqdn} with sharding ipfs/ipfs-companion#719

Merged

lidel added a commit that referenced this pull request May 13, 2019

feat: support /ipns/ at HTTP Gateway

c9fe577

It requires below to PRs to land first: #2002 ipfs/js-ipfs-http-response#19 ipfs-inactive/js-ipfs-mfs#48 License: MIT Signed-off-by: Marcin Rataj <[email protected]>

hugomrdias added 7 commits June 17, 2019 15:54

feat: add support to ipns resolve /ipns/<fqdn>

6405eea

fixes: #1918

fix: moves tests to interface-core and removes path from output

01dfa96

`ipns name resolve` dns tests moved to interface-core resolve call now return a string as per documention

fix: append remainder

183ec97

fix: remove old .path

ae83d39

fix: refactor tests

5e43cdc

enables ipns tests in the browser normalizes interface tests over core with interface tests over http-client using http api

chore: remove only in the test

2224e58

fix: make recursive true defaults, tests and more

f6f3755

fix: update deps and fix tests

c88fced

hugomrdias force-pushed the feat/name-resolve-dns branch from ef824d3 to c88fced Compare June 18, 2019 16:03

hugomrdias added 2 commits June 18, 2019 19:55

fix: tests timeout

3061c10

fix: electron tests timeout

547a66b

hugomrdias requested a review from lidel June 18, 2019 20:53

alanshaw suggested changes Jun 20, 2019

View reviewed changes

fix: fix tlru, move dep to devDep

b0c96e8

Alan Shaw added 4 commits June 22, 2019 00:21

chore: update ipfs-http-client dep

4aedf1a

fix: version range

7725a05

chore: update dep

16e8dfb

chore: update dep

0c833c3

alanshaw changed the title ~~feat: add support to ipns resolve /ipns/<fqdn>~~ feat: add support to ipns name resolve /ipns/<fqdn> Jun 24, 2019

alanshaw changed the title ~~feat: add support to ipns name resolve /ipns/<fqdn>~~ feat: add support for ipns name resolve /ipns/<fqdn> Jun 24, 2019

This was referenced Jun 24, 2019

⚡️ v0.37.0 RELEASE 🚀 #2192

Closed

Update interface-ipfs-core to the latest version 🚀 #2187

Closed

alanshaw approved these changes Jun 26, 2019

View reviewed changes

alanshaw merged commit 5044a30 into master Jun 26, 2019

lidel added a commit that referenced this pull request Jun 27, 2019

feat: support /ipns/ at HTTP Gateway

97d03fc

It requires below to PRs to land first: #2002 ipfs/js-ipfs-http-response#19 ipfs-inactive/js-ipfs-mfs#48 License: MIT Signed-off-by: Marcin Rataj <[email protected]>

djdv mentioned this pull request Jul 11, 2019

Tangents ipfs-inactive/package-managers#73

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for ipns name resolve /ipns/<fqdn> #2002

feat: add support for ipns name resolve /ipns/<fqdn> #2002

hugomrdias commented Apr 18, 2019 •

edited by alanshaw

Loading

lidel left a comment •

edited

Loading

hugomrdias commented Apr 22, 2019 •

edited by lidel

Loading

lidel commented Apr 22, 2019 •

edited

Loading

hugomrdias commented May 6, 2019

lidel left a comment •

edited

Loading

alanshaw commented May 8, 2019

hugomrdias commented May 8, 2019

alanshaw left a comment

alanshaw Jun 20, 2019

hugomrdias Jun 21, 2019

hugomrdias commented Jun 21, 2019

alanshaw commented Jun 23, 2019

alanshaw commented Jun 24, 2019

alanshaw left a comment

feat: add support for ipns name resolve /ipns/<fqdn> #2002

feat: add support for ipns name resolve /ipns/<fqdn> #2002

Conversation

hugomrdias commented Apr 18, 2019 • edited by alanshaw Loading

lidel left a comment • edited Loading

Choose a reason for hiding this comment

raw hostnames

IPNS paths

hugomrdias commented Apr 22, 2019 • edited by lidel Loading

lidel commented Apr 22, 2019 • edited Loading

hugomrdias commented May 6, 2019

lidel left a comment • edited Loading

Choose a reason for hiding this comment

alanshaw commented May 8, 2019

hugomrdias commented May 8, 2019

alanshaw left a comment

Choose a reason for hiding this comment

alanshaw Jun 20, 2019

Choose a reason for hiding this comment

hugomrdias Jun 21, 2019

Choose a reason for hiding this comment

hugomrdias commented Jun 21, 2019

alanshaw commented Jun 23, 2019

alanshaw commented Jun 24, 2019

alanshaw left a comment

Choose a reason for hiding this comment

hugomrdias commented Apr 18, 2019 •

edited by alanshaw

Loading

lidel left a comment •

edited

Loading

hugomrdias commented Apr 22, 2019 •

edited by lidel

Loading

lidel commented Apr 22, 2019 •

edited

Loading

lidel left a comment •

edited

Loading