Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: use trickle builder in daemon mode too #2085

Merged
merged 1 commit into from
May 22, 2019

Conversation

achingbrain
Copy link
Member

At the moment this doesn't work in daemon mode..

Depends on ipfs-inactive/js-ipfs-http-client#1015

@achingbrain achingbrain requested a review from alanshaw May 21, 2019 17:20
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does such a small amount of data result in different CIDs when the layout changes?

@achingbrain
Copy link
Member Author

achingbrain commented May 22, 2019

In the simplest case the balanced builder produces one unixfs file node with one or more unixfs raw or IPLD raw nodes as data leaves (depending on options passed) - when there's only one data leaf it will store the data on the file node instead - that is, collapse the tree into one node.

The trickle builder only ever stores data in leaves so the structure is different.

@alanshaw
Copy link
Member

I just updated the dag vis to use 0.36 and now I see.

@alanshaw alanshaw merged commit 62b873f into master May 22, 2019
@alanshaw alanshaw deleted the use-trickle-builder-when-specified branch May 22, 2019 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants