Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routing get|put: restore old JSON wire format #9638

Closed
Tracked by #9502
lidel opened this issue Feb 9, 2023 · 0 comments · Fixed by #9639
Closed
Tracked by #9502

routing get|put: restore old JSON wire format #9638

lidel opened this issue Feb 9, 2023 · 0 comments · Fixed by #9639
Assignees
@hacdias
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Feb 9, 2023 •
edited
Loading

Changes from ipfs/specs#351 are causing issues in bifrost-gateway, we need to restore JSON format from https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-routing-get and https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-routing-put before we ship Kubo 0.19.
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Feb 9, 2023
@lidel lidel mentioned this issue Feb 9, 2023
Merged
@hacdias hacdias mentioned this issue Feb 9, 2023
Merged
@lidel lidel changed the title routing/get|put routing get|put: restore old JSON wire format Feb 9, 2023
@lidel lidel moved this to 🏃‍♀️ In Progress in IPFS Shipyard Team Feb 9, 2023
@lidel lidel mentioned this issue Feb 9, 2023
Closed
lidel pushed a commit that referenced this issue Feb 10, 2023
@hacdias
fix: restore wire format for /api/v0/routing/get|put (#9639)
fb7f7b1 
Closes #9638
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
No open projects
IPFS Shipyard Team
Archived in project
bifrost-gateway
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: restore wire format for /api/v0/routing/get ipfs/kubo
2 participants
@lidel @hacdias