Add locking interface to blockstore #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of a locking interface to the blockstore allows us to perform atomic operations on the underlying datastore without having to worry about different operations happening in the background, such as garbage collection. License: MIT Signed-off-by: Jeromy <[email protected]>
This commit improves (fixes) the FetchGraph call for recursively fetching every descendant node of a given merkledag node. This operation should be the simplest way of ensuring that you have replicated a dag locally. This commit also implements a method in the merkledag package called EnumerateChildren, this method is used to get a set of the keys of every descendant node of the given node. All keys found are noted in the passed in KeySet, which may in the future be implemented on disk to avoid excessive memory consumption. License: MIT Signed-off-by: Jeromy <[email protected]>
|
|
||
| if live == 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
what is live used for? it's incorrect. it's not decremented and will never go below 1.
There was a problem hiding this comment.
its correct. i guess i could make it clearer by turning live += len(keys) - 1 into live += len(keys) and live--
|
3 comments above |
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
locking-blockstore
branch
from
4f019d2 to
05cd3fc
Compare
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
|
Final changes:
|
License: MIT Signed-off-by: Juan Batiz-Benet <[email protected]>
|
@jbenet this RFM? |
|
I think so (rebase first?) |
jbenet
added a commit
that referenced
this pull request
Jul 9, 2015
Add locking interface to blockstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of a locking interface to the blockstore allows us to
perform atomic operations on the underlying datastore without having to
worry about different operations happening in the background, such as
garbage collection.
Also implement a few merkledag package changes.
License: MIT
Signed-off-by: Jeromy [email protected]