Added Default logic to publish #2677
Conversation
| return | ||
| } | ||
| verif, _, _ := req.Option("resolve").Bool() | ||
| popts.verifyExists = verif |
There was a problem hiding this comment.
popts.verifyExists, _, _ := req.Option("resolve").Bool()?
There was a problem hiding this comment.
Yeah, I was wrong. Removed that commend after little longer thinking.
There was a problem hiding this comment.
Well, actually - it may be smart to only set it to verif if it is found. The logic is slightly different, this way.
There was a problem hiding this comment.
Does it make any difference? It is by default true, you can change it only by doing --verify=false.
There was a problem hiding this comment.
I think what @RichardLitt proposed in his first comment is best, except use = instead of := since we're not declaring any new variables.
There was a problem hiding this comment.
and then we can also change the popts declaration to just:
popts := new(publishOpts)
Part of #2484 License: MIT Signed-off-by: Richard Littauer <[email protected]>
RichardLitt
force-pushed
the
feature/add-default-to-publish
branch
from
a4f1f71 to
475d730
Compare
RichardLitt
added
need/review
Part of #2484
License: MIT
Signed-off-by: Richard Littauer [email protected]