implement a worker to consolidate HasBlock provide calls into one #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alieviate memory pressure
| case bs.provideKeys <- nextKey: | ||
| if len(toprovide) > 0 { | ||
| nextKey = toprovide[0] | ||
| toprovide = toprovide[1:] |
There was a problem hiding this comment.
I see three select{}s in here which are very similar.
If you only switch on the bs.provideKeys <- nextKey after nextKey != nil, this can be one for { select {}} IMHO.
ps: s/toprovide/toProvide/ for the pedantics. 😄
| if !ok { | ||
| log.Debug("newBlocks channel closed") | ||
| log.Debug("provideKeys channel closed") | ||
| return | ||
| } | ||
| ctx, _ := context.WithTimeout(ctx, provideTimeout) |
|
LGTM |
|
jbenet
added a commit
that referenced
this pull request
Mar 6, 2015
implement a worker to consolidate HasBlock provide calls into one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR grabs all the keys that need to be provided and consolidates them into a single buffer of keys. In doing so, it releases the reference to the block being provided, allowing the GC to remove it from memory, and also preventing the HasBlock goroutines from building up blocking on provide sends.