Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go-unixfs to v0.4.3 #9643

Merged
merged 3 commits into from
Feb 23, 2023
Merged

chore: bump go-unixfs to v0.4.3 #9643

merged 3 commits into from
Feb 23, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Feb 9, 2023

Includes fixes for GHSA-q264-w97q-q778.

Based on: #9647

@lidel
Copy link
Member

lidel commented Feb 14, 2023

ipfs/boxo#164 is merged, and until this PR is also merged, it will be breaking gateway tests: ipfs/boxo#167 (comment)

@Jorropo is this something you are able to resolve any time soon, or do we need to figure out alternative way of testing gateway code?

@Jorropo
Copy link
Contributor Author

Jorropo commented Feb 14, 2023

@lidel I pushed rcmgr fixes there: #9647

@Jorropo Jorropo force-pushed the bump-go-unixfs branch 2 times, most recently from d2f0e62 to e19eec0 Compare February 14, 2023 13:20
@BigLep BigLep requested a review from lidel February 14, 2023 18:12
@Jorropo Jorropo force-pushed the bump-go-unixfs branch 2 times, most recently from aef9c7d to 5503af4 Compare February 14, 2023 21:03
@hacdias hacdias self-requested a review February 22, 2023 15:26
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I'll just wait for CI to merge.

I will be merging as the failures are related to the libp2p tests flakyness which should be addressed by another PR.

@hacdias hacdias merged commit f73cd19 into ipfs:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants