Issue #186 more basic IP tools #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 new files added each in lib and ipinfo folders and modified the cmd_tool.go file to support the is_loopback and is_multicast tool
Added two new files to the lib and ipinfo folders and also modified the cmd_tool.go file in ipinfo folder to add the is_unspecified tool for use
All tools that were asked for in issue ipinfo#186 have been added, the relevent files can be found in the lib and ipinfo directories modifications were made to the cmd_tool.go file in ipinfo directory for the tools to be usable within the cli
UmanShahzad
reviewed
Nov 20, 2023
UmanShahzad
reviewed
Nov 20, 2023
|
@UmanShahzad kindly review |
UmanShahzad
suggested changes
Nov 20, 2023
UmanShahzad
reviewed
Nov 21, 2023
There was a problem hiding this comment.
- Command examples are not real it seems. Please make sure you run each command, including your own examples, and that they work and produce the expected results!
- Error handling? I guess we can copy the is_v4/is_v6 style for now where it's printed. See those files.
UmanShahzad
suggested changes
Nov 27, 2023
UmanShahzad
suggested changes
Nov 27, 2023
UmanShahzad
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished adding all the basic IP Tools which include:
is_loopback
is_multicast
is_unspecified
is_global_unicast
is_interface_local_multicast
is_link_local_multicast
is_link_local_unicast
All new .go files can be found in the ipinfo and lib directories with the file name cmd_tool_NAME OF TOOL also the cmd_tool.go file was modified to allow access to the tools via the cli