Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added isEU #40

Merged
merged 2 commits into from
Aug 18, 2022
Merged

added isEU #40

merged 2 commits into from
Aug 18, 2022

Conversation

rm-Umar
Copy link
Contributor

@rm-Umar rm-Umar commented Aug 17, 2022

No description provided.

@rm-Umar rm-Umar requested a review from UmanShahzad August 17, 2022 10:18
UmanShahzad
UmanShahzad suggested changes Aug 17, 2022
View reviewed changes
ipinfo/countries.go Outdated Show resolved Hide resolved
@rm-Umar rm-Umar requested a review from UmanShahzad August 17, 2022 10:55
UmanShahzad
UmanShahzad reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing - if we give it a key that isn't found, won't this crash or something? This could happen in some edge cases I believe with contested countries.

@rm-Umar
Copy link
Contributor Author

rm-Umar commented Aug 17, 2022

Looks good, just one thing - if we give it a key that isn't found, won't this crash or something? This could happen in some edge cases I believe with contested countries.

It just returns an empty string and false, so no issues about that

fmt.Println(countriesMap["UMAR"])
// { false}

@UmanShahzad UmanShahzad merged commit 48b028e into master Aug 18, 2022
@UmanShahzad UmanShahzad deleted the umar/isEU branch August 18, 2022 04:54
@UmanShahzad
Copy link
Contributor

Will be releasing it later.

@coderholic
Copy link
Member

See comment here ipinfo/python#61 (comment)

Source file format needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UmanShahzad UmanShahzad UmanShahzad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rm-Umar @UmanShahzad @coderholic