added custom 409 response #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmanShahzad
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Not the right place to put this I'd say, and not like this either, seems like a huge hack to pretend like this is the real response.
We should be checking the actual response code on the client of this library and printing the message. Or modifying the String function of ErrorResponse so that if it's 429 status code, we print our custom msg.
UmanShahzad
approved these changes
Mar 15, 2023
|
@rm-Umar let's make a new release then for this (patch vsn) and make it available to the cli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.