v0.18 tracking #444
Closed
v0.18 tracking #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kinds also adds tests, and typed functions that must be used in the interface
Can handle maps, lists and all scalar kinds; a receiving Go type that is registered as a CustomTypeAnyConverter will receive a datamodel.Node and is expected to return one when converting to and from that custom Go type.
API docs are too verbose
For centralising bindnode setup - register a type & schema once and not have to worry about the TypedPrototype or direct bindnode calls after that. It also caches bindnode Options that may go along with the type. This could have been a global registry, but there exists a possibility of the same type wanting to be used by different users in the same application instance but with different schemas and/or Options. So instead, the question of it being a global is left to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in both #414 and #437 here. Mainly because I want to use them and don't want to merge them into master just yet. I'll do #414 when 0.17.0 is done though.