This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
feat+fix: implement .tree and fix how the resolver was working #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also make sure to check ipld/interface-ipld-format#5 |
Merged
|
sgtm |
nicola
reviewed
Mar 13, 2017
| } | ||
| // TODO by enabling something to resolve through link name, we are | ||
| // applying a transformation (a view) to the data, confirm if this | ||
| // is exactly what we want |
There was a problem hiding this comment.
is this a todo or a question? :)
There was a problem hiding this comment.
TODO: Ask the question:.... :D
nicola
reviewed
Mar 13, 2017
| values[i] = { | ||
| hash: link.multihash, | ||
| name: link.name, | ||
| size: link.size |
There was a problem hiding this comment.
It is the size of this branch of the graph so far. It is needed to avoid traversing graphs over and over. go-ipfs has it since forever.
src/resolver.js
Outdated
| @@ -1,10 +1,9 @@ | |||
| 'use strict' | |||
|
|
|||
| const util = require('./util') | |||
| const bs58 = require('bs58') | |||
| // const bs58 = require('bs58') | |||
There was a problem hiding this comment.
please delete if you are not using it
src/resolver.js
Outdated
| split.shift() | ||
| split.shift() | ||
|
|
||
| remainderPath = split.join('/') |
There was a problem hiding this comment.
these 4 lines could be simply
remainderPath = split.slice(3).join('/')| if (node.data && node.data.length > 0) { | ||
| paths.push({ path: 'data', value: node.data }) | ||
| } | ||
| paths.push('Data') |
There was a problem hiding this comment.
The above can be simplified to
const links = node.links.map((l, i) => ([
`Links/${i}/Name`,
`Links/${i}/Tsize`,
`Links/${i}/Hash`
])
links.push('Data')
const paths = Array.prototype.concat.apply(['Links'], links)
src/resolver.js
Outdated
|
|
||
| callback(null, paths) | ||
| }) | ||
| } | ||
|
|
||
| /* | ||
| * isLink: returns the Link if a given path in a block is a LInk, false otherwise |
src/resolver.js
Outdated
| } | ||
|
|
||
| if (typeof result.value === 'object' && result.value['/']) { | ||
| // result.value['/'] = bs58.encode(result.value['/']) |
There was a problem hiding this comment.
please remove if not used
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of implementing .tree, I've realized how we fell into the trap of 'transforming' the original data for convenience, for example, it was not possible to access the fields 'Name' or 'Tsize' of the protobuf, because we were handling the links as a direct jump to other objects.
This PR: