Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader-privacy (double-hashed) lookups by default #13

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented Sep 22, 2023

Update go-naam to use current go-libipni and to do reader-privacy (double-hashed) indexer lookups by default.

Fixes #11

Create test with running indexer and dhstore

Fixes #12

Other changes:

  • Update go version
  • Update README with runnable example
  • Option for separate lookup and announce URLs
  • Update to use current IPNS and IPFS path libraries

@gammazero gammazero requested a review from masih September 22, 2023 19:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (604d44f) 0.00% compared to head (41336e4) 48.58%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           main      #13       +/-   ##
=========================================
+ Coverage      0   48.58%   +48.58%     
=========================================
  Files         0        2        +2     
  Lines         0      389      +389     
=========================================
+ Hits          0      189      +189     
- Misses        0      153      +153     
- Partials      0       47       +47     
Files Coverage Δ
options.go 56.48% <72.00%> (ø)
naam.go 45.55% <53.78%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update go-naam to use current go-libipni and to do reader-privacy (double-hashed) indexer lookups by default.

Fixes #11

Create test with running indexer and dhstore

Fixes #12

- Update go version
- Update README with runnable example
- Option for separate lookup and announce URLs
- Update to use current IPNS and IPFS path libraries
@gammazero gammazero force-pushed the enable-reader-privacy branch from eed52b1 to 4f1af31 Compare September 23, 2023 05:35
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@gammazero gammazero merged commit a7bb6dd into main Sep 26, 2023
@gammazero gammazero deleted the enable-reader-privacy branch September 26, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create test with running indexer and dhstore Do reader-privacy (double-hashed) indexer lookups by default
3 participants