Specify publisher and provider addresses #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The publisher address is used to tell IPNI where to fetch advertisements from. It may be a public address different from the publisher listen address. So, it is necessary to explicitly specify the address. The provider address is the provider address part of an advertisement. IPNI may require that this be a routable address and reject the advertisement if it is not. So, it is necessary to specify this address.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 52.10% 52.08% -0.02%
==========================================
Files 2 2
Lines 380 407 +27
==========================================
+ Hits 198 212 +14
- Misses 139 150 +11
- Partials 43 45 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publisher address is used to tell IPNI where to fetch advertisements from. It may be a public address different from the publisher listen address. So, it is necessary to explicitly specify the address.
The provider address is the provider address part of an advertisement. IPNI may require that this be a routable address and reject the advertisement if it is not. So, it is necessary to specify this address.