Remove u string prefixes #598
Conversation
the u prefixes dont do anything on Python 3 and they are unnecessary noise in the code modified: docs/source/conf.py modified: docs/source/config.rst modified: examples/myapp.py modified: traitlets/config/application.py modified: traitlets/config/configurable.py modified: traitlets/config/tests/test_application.py modified: traitlets/config/tests/test_configurable.py modified: traitlets/config/tests/test_loader.py modified: traitlets/tests/test_traitlets.py modified: traitlets/utils/tests/test_importstring.py
|
Thanks ! I'll have a look at try to get this in the next release ; We usually tend to avoid large scale PR that change all the file as it breaks If this is not the only project you do that one; these changes can be automatically applied via https://github.com/asottile/pyupgrade I'm also working on improving darker to apply upgrade only on changed lines which would have the advantage to progressively update the codebase w/o breaking git blame. |
| @@ -1229,7 +1229,7 @@ class AnyTraitTest(TraitTestBase): | |||
| obj = AnyTrait() | |||
|
|
|||
| _default_value = None | |||
| _good_values = [10.0, 'ten', u'ten', [10], {'ten': 10},(10,), None, 1j] | |||
| _good_values = [10.0, 'ten', [10], {'ten': 10},(10,), None, 1j] | |||
There was a problem hiding this comment.
👍 nice catch, pyupgrade would not find this !
|
I have to run into a meeting but that looks good to me ! |
I've seen different strategies on different projects - some which prefer to make all of the stylistic upgrades in a single PR - squash merged into a single commit. That way, history is only broken in one commit. I can also understand/appreciate making modular changes only in parts of code/files in project which are modified in various PRs. I guess the downside with that approach is that some parts of the codebase are more readable than others - especially if the project as a whole moves slower in general. I leave it up to y'all to decide what the strategy for traitlets is. |
|
for new contribution we'll like not reject them, but I've been bitten enough by large changes and it breaking git-bisect that I'm usually on the fence. Git blame now have the option to ignore some commit, but it's not avail via github... Anyway thank, this is a great first contribution, it will make the 5.x codebase cleaner ! |
|
thanks @Carreau |
This PR removes the
uprefixes on strings. The prefixes dont do anything on Python 3 and they are unnecessary noise in the code.Note that this PR is one PR in a series of PRs that aim to remove Python 2 support from the code base. This PR has been standalone given the volume of changes and to aid in the review process.