Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus last focused element on modal close – restored after wrong merge #533

Closed
wants to merge 1 commit into from

Conversation

Morpheu5
Copy link
Contributor

Sorry Chris!

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #533 (b65fc80) into master (7456360) will increase coverage by 0.01%.
The diff coverage is 43.75%.

❗ Current head b65fc80 differs from pull request most recent head 866cd75. Consider uploading reports for the commit 866cd75 to get more accurate results

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   30.34%   30.35%   +0.01%     
==========================================
  Files         310      311       +1     
  Lines       15857    15873      +16     
  Branches     4478     4483       +5     
==========================================
+ Hits         4812     4819       +7     
- Misses      10943    10952       +9     
  Partials      102      102              
Impacted Files Coverage Δ
src/app/state/modalFocusMiddleware.ts 40.00% <40.00%> (ø)
src/app/state/store.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7456360...866cd75. Read the comment docs.

@chrisjpurdy
Copy link
Contributor

Well, looks like bootstrap actually does this itself, and it works with multiple modals. Oops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants