Add 'allowWindowsEscape' option #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Glob pattern is a some kind of language. It SHOULD be one for any platform. |
This was referenced Feb 16, 2017
isaacs
reviewed
Feb 13, 2022
| @@ -709,7 +709,7 @@ function match (f, partial) { | |||
| var options = this.options | |||
|
|
|||
| // windows: need to use /, not \ | |||
| if (path.sep !== '/') { | |||
| if (!options.allowWindowsEscape && path.sep !== '/') { | |||
There was a problem hiding this comment.
This should still be done. Even if we aren't forcing \ to be a path separator in the pattern, we still need to make the path we're matching use / characters.
|
This is a good step towards just not treating |
afzalimdad9
added a commit
to afzalimdad9/minimatch
that referenced
this pull request
Jan 18, 2025
PR-URL: isaacs/minimatch#103 Credit: @frandiox Close: #103 Reviewed-by: @isaacs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@isaacs This is a minimum PR that fixes #50 #64 isaacs/node-glob#212 and maybe something else.
Since
node-globpasses theoptionsobject directly tominimatchit shouldn't be necessary to updatenode-glob. It won't break existing code either since by default this flag isundefined. Basically if this is set, the caller have to make sure the provided string does not contain\for path separator, only for escaping characters.