Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PEP 503 environment markers to control ML dependency installation #6588

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented Jan 10, 2024

Type

Motivation and Context

As explained in #5747, any Python environment management tool that uses the PyPI JSON API when performing dependency resolution will receive inconsistent dependency results for Open3D. An example tool that Open3D is currently incompatible with is Poetry.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Unconditionally include ML dependencies in all built wheels, and use PEP 508 environment markers to control which platforms they are installed into.

Copy link

update-docs bot commented Jan 10, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@johnthagen
Copy link
Contributor Author

@ssheorey Here is a draft PR of the concept for fixing #5747. I am not familiar with Open3D's build process, so will likely need your assistance, but this should be a starting point.

Feel free to make edits to this PR.

@apockill
Copy link

You're a hero @johnthagen, thank you for looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open3d 0.16.1 fails to install correct dependencies under Poetry
2 participants