-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pt_BR override translation not working #982
Comments
Differing internal representations of two-level language codes, e.g. pt_BR/pt_PT or zh_CN/zh_TW, would lead to inconsistencies when combined with overrides of i18n strings for templating. E.g. setting data-isso-lang=pt_BR and data-isso-postbox-text-text-PT_BR would result in an internal representation of data-isso-postbox-text-text-pt-br (note: lowercase) and thus user-supplied i18n strings not being applied. To make this handling more robust, convert everything into lowercase and substitute underscores for dashes. Fixes isso-comments#982
Thank you @ix5 ! Sorry, for some reason I did not receive the notification of the reply. Only saw now. |
The docs should help you here: Install Isso from source In short, for only testing the updated Javascript file: You can also grab the updated |
@ix5 OK, tested. Now it works fine. Thank you! |
Checklist
master
branch does not fix my issueWhat is not working?
Overriding translation string for pt_BR (brazilian portuguese) is ignored. This is specific to this language. When I change to
en
, it works.How can one reproduce this issue?
It didn't work from the beginning, in an Ubuntu Server 20.04, Python 3.8.10, pip 20.0.2.
My script tag:
The text was updated successfully, but these errors were encountered: