views: moderation: Add unit tests, proper response instead of "Yo", apiDoc clarifications

[fliiiix]

Things this PR addresses:

• Replace Yo response from moderation with a more appropriate response
• Add tests for moderation
• Add tests for unsubscribe and fix doc string

Contributes to #755

[ix5]

Nice effort! Some minor nits here and there.

Please also keep commit message titles under 50 chars (or at least under 70, if otherwise not possible), else GitHub will hard-break the title with ellipses.

[fliiiix]

Thanks for the review 🎉 i addressed all your feedback, take an other look if you spot any issues

Except the thing with the git commit message length, im not to sure what i should do there I can drop the prefix to make them shorter, but i guess the idea is to use prefixes? I can create super short unspecific commit messages which i feel would be worse.
So i am a bit lost how i should solve that any ideas?

[ix5]

Except the thing with the git commit message length, im not to sure what i should do there I can drop the prefix to make them shorter, but i guess the idea is to use prefixes? I can create super short unspecific commit messages which i feel would be worse. So i am a bit lost how i should solve that any ideas?

Don't worry too much about that. Those commit message conventions are just that, conventions. I personally use abbreviations or more terse wording and kind of "force" myself to keep below 50 chars, as I've set my editor to "warn" me when I go over.

E.g.

views: comments: moderation: Replace Yo response with a more descriptive text

I'd replace with

views: comments: Proper response instead of 'Yo'

But again, that's just stylistic pet peeves. You'll notice the usefulness of short commit messages when browsing git logs and being annoyed at the cut-off messages ending in ellipses.

---

Thanks for those tests. One inline comment, everything else looks marvelous!

[ix5]

Verified using make test and npm i apidoc; npx apidoc --config apidoc.json --input isso/ --output _apidoc/

Thank you for your contribution!