Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: Support and test against Python 3.11 #832

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

fliiiix
Copy link
Contributor

@fliiiix fliiiix commented Mar 28, 2022

No description provided.

@ix5
Copy link
Member

ix5 commented Mar 28, 2022

Nice effort, thanks for doing this.
Let's wait for the dependencies to become available for 3.11, keeping this open until then.

See also: 3.11 release schedule

@ix5 ix5 added feature testing/ci Test coverage & GitHub actions etc. labels Apr 23, 2022
@ix5 ix5 added this to the backburner milestone May 27, 2022
@fliiiix fliiiix force-pushed the feature/test-against-latest branch 3 times, most recently from 055c353 to 2574e5d Compare October 29, 2022 09:17
@fliiiix
Copy link
Contributor Author

fliiiix commented Oct 29, 2022

It might make sense to also upgrade the Dockerfile but i could not tst that so its not included

 => ERROR [isso-builder  3/11] RUN python3 -m venv /isso  && . /isso/bin/activate  && pip3 install --no-cache-dir --upgrade pip  && pip3 install --no-cache-dir gu  0.5s

and update the docs build
https://github.com/posativ/isso/blob/master/.github/workflows/build-upload-docs.yml#L27

same issue here no idea how to test so i did not upgrade it

But I think this PR is ready to go

@ix5
Copy link
Member

ix5 commented Oct 30, 2022

Time indeed moves fast... Totally forgot about this. Would you mind pinging me about this on Wednesday?

@fliiiix
Copy link
Contributor Author

fliiiix commented Nov 2, 2022

ping

@ix5 ix5 changed the title github-action: tests agains 3.11.0-alpha.6 treewide: Support and test against Python 3.11 Nov 2, 2022
@ix5
Copy link
Member

ix5 commented Nov 2, 2022

Please amend the slight wording suggestion, and create a separate commit for the setup.py change.

Otherwise LGTM

CHANGES.rst Outdated Show resolved Hide resolved
@fliiiix fliiiix requested a review from ix5 November 3, 2022 10:19
@fliiiix
Copy link
Contributor Author

fliiiix commented Nov 3, 2022

I think i addressed all the feedback let me know if there is something else missing to get this merged

@ix5 ix5 merged commit e1a6291 into isso-comments:master Nov 3, 2022
@ix5
Copy link
Member

ix5 commented Nov 3, 2022

Thanks your your contribution and patience!

@fliiiix fliiiix deleted the feature/test-against-latest branch November 9, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature testing/ci Test coverage & GitHub actions etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants