fix: upgrade to newer versions of source-map, signal-exit, and instrument #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcoe I'll try this out, thanks! |
|
@bcoe this branch works great for me. |
added 4 commits
September 13, 2016 09:57
|
@mourner seeing any significant performance gains, vs. |
|
@bcoe seeing the same performance gains I described in istanbuljs-archived-repos/istanbul-lib-instrument#22 |
bcoe
force-pushed
the
upgrade-dependencies
branch
from
6d44313 to
aa06525
Compare
|
@mourner cool, was curious if spawning yargs less frequently (which I believe has a 100ms overhead) would improve performance further -- this would specifically target people using |
|
@bcoe it probably shaved off a few hundred ms, but it's not really noticeable with a test suite that runs for 6+ minutes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few somewhat frightening dependencies being upgraded, we should test thoroughly.
@mourner mind taking this for a spin, it's what actually lands your performance fixes (along with some performance fixes I snuck into #388, yargs should now execute much less frequently).