improve ratelimit doc #11654
Merged
improve ratelimit doc #11654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
|
@kyessenov can you review this? it seems good at first pass, but i'd like a more rate-limit savvy set of eyes to confirm. |
|
@kyessenov Any thoughts? Thanks. |
kyessenov
approved these changes
Aug 17, 2022
ericvn
reviewed
Aug 17, 2022
Comment on lines
54
to
60
| # wait a while for envoyfilter | ||
| sleep 1s | ||
|
|
||
| for i in {1..10}; do | ||
| echo "$i" | ||
| snip_verify_local_rate_limit_1 | ||
| done |
There was a problem hiding this comment.
Is this just extra debugging? The verify_same should repeat the snip_verify_local_rate_limit_1 and compare output until the condition is met or the retries have expired.
There was a problem hiding this comment.
you're right, I misunderstand the usage of _verify_same.
will fix this, thanks!
| snip_global_rate_limit_4 | ||
|
|
||
| # verify global ratelimit | ||
| snip_verify_global_rate_limit_1 |
There was a problem hiding this comment.
I don't think this line is needed, as it's done as part of the next line.
ericvn
approved these changes
Aug 18, 2022
|
In response to a cherrypick label: new pull request created: #11717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description for what this PR is for.
fix: #10372
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.