Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom internal functions #46

Merged
merged 8 commits into from
Dec 6, 2020
Merged

Support custom internal functions #46

merged 8 commits into from
Dec 6, 2020

Conversation

itchyny
Copy link
Owner

@itchyny itchyny commented Nov 24, 2020

This pull request implements custom internal functions (close #43).

@wader
Copy link
Contributor

wader commented Dec 4, 2020

Should customFuncs be passed along in the new compiler struct in compileModule and compileFuncDef?

@wader
Copy link
Contributor

wader commented Dec 4, 2020

Thanks, looks good to me! I did something similar but much uglier. I will port my code that uses gojq to use this branch instead, probably later today, if you want to wait with merge until i've tested?

@itchyny itchyny force-pushed the add-custom-funcs branch 3 times, most recently from 383d267 to 2c878dc Compare December 5, 2020 10:37
@itchyny itchyny merged commit 63b687e into master Dec 6, 2020
@itchyny itchyny deleted the add-custom-funcs branch December 6, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for functions written in go when used as a library
2 participants