Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLD: dvc pkg cmd ref (and other misc updates) #388

Closed
wants to merge 8 commits into from
Closed

OLD: dvc pkg cmd ref (and other misc updates) #388

wants to merge 8 commits into from

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented May 29, 2019 •
edited
Loading

Review app will be at https://dvc-org-pr-388.herokuapp.com/

Closes #385

@jorgeorpinel jorgeorpinel mentioned this pull request May 29, 2019
Closed
@jorgeorpinel jorgeorpinel changed the title WIP: dvc pkg command ref. WIP: dvc pkg cmd ref (and other misc updates) May 30, 2019
@jorgeorpinel jorgeorpinel requested review from shcheklein and efiop June 3, 2019 23:50
@shcheklein shcheklein temporarily deployed to dvc-org-pr-388 June 3, 2019 23:52 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-388 June 4, 2019 17:14 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jun 4, 2019 •
edited
Loading

@shcheklein this is soon to be a regular non-WIP PR. You may want to start reviewing the "other misc." changes in it, the ones not related to dvc pkg commands – when you get a chance. Thanks

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-388 June 5, 2019 02:00 Inactive
@jorgeorpinel jorgeorpinel changed the title WIP: dvc pkg cmd ref (and other misc updates) dvc pkg cmd ref (and other misc updates) Jun 5, 2019
@jorgeorpinel
Adds initial pkg and pgk-install cmd refs.
015259f 
WIP
@jorgeorpinel
Removes accidental lose empty text files
87678fa
@jorgeorpinel
Adds note on credentials to dvc remote modify and other related cmd…
7df0c64 
… refs

Per https://discordapp.com/channels/485586884165107732/485596304961962003/583696642197159946
@jorgeorpinel
Updates dvc pkg install cmd ref to current core dvc repo master beh…
b45ead5 
…avior.
@jorgeorpinel
WIP: Adds 4/6 dvc pkg subcommand ref files.
142a2d2
@jorgeorpinel
First complete version of initial 4 pkg subcommands.
2f4cb72
@jorgeorpinel
Update to first 4 pkg commads per efiop/pkgs branch
e70988c 
From upstream [email protected]:efiop/dvc.git

For #385
@jorgeorpinel
Finish all pkg file up to current dev version
0e3f11b 
(See https://github.com/efiop/dvc/tree/pkgs)

- Update a few usages in first 4 commands
- Link all commands together in their intros
- Add list, modify, and import with basic examples
- Related changes in `cache dir` and `remote modify` cmd refs

For #385
@jorgeorpinel jorgeorpinel changed the title dvc pkg cmd ref (and other misc updates) WIP: dvc pkg cmd ref (and other misc updates) Jun 7, 2019
@jorgeorpinel jorgeorpinel removed the request for review from efiop June 7, 2019 03:43
@jorgeorpinel
Copy link
Contributor Author

Given that the pkg commands functionality is still highly WIP and there are other PRs I want to send to this repo, I'm closing this PR and reopening from another branch. See #417

@jorgeorpinel jorgeorpinel changed the title WIP: dvc pkg cmd ref (and other misc updates) OLD: dvc pkg cmd ref (and other misc updates) Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein Awaiting requested review from shcheklein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document dvc import and dvc get (previously pkg commands)
2 participants
@jorgeorpinel @shcheklein