-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added git-push in docs #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor changes
along with 'git commit' and | ||
[git push](https://git-scm.com/docs/git-push/1.5.5.2). | ||
The `dvc push` command allows one to upload data to remote storage. It is | ||
usually run along with `git commit` and `git push`. `dvc push` and `git push` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intention is not to explain the command (git push), but to emphasize that dvc push
is not doing anything magical, that it's not running git push for you or something. It's already done by the first two sentences to some extent. I would just modify them a little bit to be more specific:
The
dvc push
command allows one to upload data to remote storage. It does not save changes to code or DVC-files. You still need to rungit commit
andgit push
to save them.
Something like this ^^
@jorgeorpinel could you take a look, does the phrase above look reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `dvc push` command allows one to upload data to remote storage. It doesn't
update any modified changes in the code or DVC-files. The changes made in the
the files or addition of any new file still needs to be saved by using
`git commit` and `git push`.
Is it good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update any modified change
-> save any changes
"The changes made in the the files or addition of any new file still" -> Those should be saved ...
The `dvc push` command allows one to upload data to remote storage. It doesn't | ||
save any changes in the code or DVC-files. Those should be saved by using | ||
`git commit` and `git push`. | ||
|
||
See `dvc push` for more details and options for this command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was a little distracted last week. I do like the paragraph you guys came up with, but I will remove the paragraph separation above in my active PR for this doc. Thanks
UPDATE: Actually I'll just remove the separate sentence since the link to dvc push
is already up there.
Fix #452