Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: regular update (early August) #522

Merged
merged 16 commits into from
Aug 10, 2019
Merged

docs: regular update (early August) #522

merged 16 commits into from
Aug 10, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Aug 6, 2019

No description provided.

@jorgeorpinel jorgeorpinel changed the title cmd ref: advanced examples for import and update; et al [WIP] docs: regular update (late July) Aug 7, 2019
@jorgeorpinel jorgeorpinel changed the title docs: regular update (late July) docs: regular update (early August) Aug 7, 2019
@jorgeorpinel jorgeorpinel requested a review from shcheklein August 7, 2019 05:22
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff! just a couple of minor comments to address

project when [\`dvc init\`](/doc/commands-reference/init) is run, and
[DVC-files](/doc/user-guide/dvc-file-format) are created in it. It\s typically
also a Git repository.
`

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your question is whether the linter will fix lines that go over 80 chars, no. Neither with the previous or with this format does it fix them, neither with the hook nor run manually 🙁. It seems to leave strings alone.

Is that another issue to report to Aman?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can def check if it's possible to configure it to fix them. In any case, I don't mind the format you suggested, its' def easier to support manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @algomaster99 what do you think? (about pretty-quick being able to warp strings in js files)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a bit strange, but let's try

Applied new format to all glossary entries in 8781a71

@shcheklein

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@shcheklein

This comment has been minimized.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Aug 10, 2019

I just thought that we are almost ready to merge this one.

I wish haha... I have lots of changes after reviewing the usage of the term "workspace" per a comment somewhere in this PR

BUT I just realized that should go in it's own PR! So I saved that work separately and just pushed changes for the pending comments above. Please check @shcheklein (:

  • I'll resolve conflicts now.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🎉 !

@shcheklein shcheklein merged commit f9b9e33 into iterative:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants