Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get-started: update Get Started accord to most recent example-get-started repo #555

Merged
merged 13 commits into from
Aug 23, 2019
Merged

get-started: update Get Started accord to most recent example-get-started repo #555

merged 13 commits into from
Aug 23, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Aug 13, 2019 •
edited
Loading

@jorgeorpinel jorgeorpinel changed the title cmd ref: advanced examples for import [WIP] cmd ref: advanced examples and repos for import, get, update [WIP] Aug 13, 2019
@jorgeorpinel
Copy link
Contributor Author

Note: the last couple commits here are to fix #554

@jorgeorpinel jorgeorpinel changed the title cmd ref: advanced examples and repos for import, get, update [WIP] get-started: update and regenerate example-get-started repo and Get Started section accordingly Aug 22, 2019
jorgeorpinel referenced this pull request in iterative/example-repos-dev Aug 23, 2019
@jorgeorpinel
fix typo in example-get-started/generate.sh
93bc016
@jorgeorpinel jorgeorpinel changed the title get-started: update and regenerate example-get-started repo and Get Started section accordingly get-started: update Get Started accord to most recent example-get-started repo Aug 23, 2019
@shcheklein shcheklein temporarily deployed to dvc-org-pr-555 August 23, 2019 08:22 Inactive
@jorgeorpinel

This comment has been minimized.

Sign in to view
shcheklein
shcheklein requested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a few minor comments.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-555 August 23, 2019 21:36 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-555 August 23, 2019 21:49 Inactive
@shcheklein shcheklein merged commit c93fe83 into iterative:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lint: inconsistent fenced code block -line indentation
2 participants
@jorgeorpinel @shcheklein