term: "metric" and related; other regular updates #611
Conversation
jorgeorpinel
changed the title
| repo. | ||
|
|
||
| Note that the required `path` is expected to point to a file or directory | ||
| defined in one of the [DVC-files](/doc/user-guide/dvc-file-format) in the source |
There was a problem hiding this comment.
@shcheklein to your comment in 1fd6c11#r35008668,
defined -> controlled? referenced? I don't like that it sounds here like DVC-files come first and data second, while we always should be emphasizing that DVC-files are helpers/meta for data.
Hmmm OK updated here but we use this language in a bunch of other places, let me review...
There was a problem hiding this comment.
OK, reviewed throughout in my latest commit in this PR.
There was a problem hiding this comment.
I'm not sure we need to make a strict rule or fix other places. It's just in this case when we try to emphasize and explain that it expects data reference I would be careful with wording and usage of DVC-file stuff.
There was a problem hiding this comment.
Hmm well it's not obvious to me when wording changes should or not propagate throughout all docs. (I like to do this generally, for consistency.) Do you think the default should be to avoid that? It's typically a quick "grep", but some times it can become pretty time consuming to check everything.
in the context of metric files (avoided). per
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@jorgeorpinel I think it's more or less ready to be merged - please resolve the conflicts and let me know when it's ready :) |
|
Resolved (: |
No description provided.