Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brew instructions #737

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Update brew instructions #737

merged 3 commits into from
Oct 25, 2019

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Oct 24, 2019

IMPORTANT NOTES (please read, then delete):

  • Have you followed the guidelines in
    Contributing Documentation?

  • The PR title should start with "Fix #bugnum: " (if applicable), followed by a
    clear one-line present-tense summary of the changes introduced in the PR. For
    example: "Fix #bugnum: Introduce the first version of the collection editor.".

  • Please make sure to mention "Fix #bugnum" (if applicable) somewhere in the
    description of the PR. This enables GitHub to link the PR to the corresponding
    bug.

@efiop efiop requested a review from jorgeorpinel October 24, 2019 23:01
@dashohoxha
Copy link
Contributor

This PR is going to conflict with this unmerged PR: #734
because static/docs/get-started/install.md has been removed, and static/docs/user-guide/install/macos.md has been moved to static/docs/install/macos.md.
I don't know why it's merge is being delayed.

@shcheklein
Copy link
Member

So, I would not worry about conflicts in this case - both PRs are very simple. That's what merge (or rebase) are for, right?

No specific reason to keep your PR unmerged, @dashohoxha, just haven't had enough time to take a look yet - a pretty hectic day today :)

@shcheklein shcheklein merged commit b64f02a into iterative:master Oct 25, 2019
@efiop efiop deleted the brew branch October 25, 2019 21:24
jorgeorpinel added a commit that referenced this pull request Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants