Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: remove a couple more "(s)" left #2299

Merged
merged 3 commits into from
Jul 20, 2019
Merged

output: remove a couple more "(s)" left #2299

merged 3 commits into from
Jul 20, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jul 19, 2019

Continuation of #2281 (comment)

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.


Doc update: iterative/dvc.org@3dc5489

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jul 19, 2019

Note the tests are failing due to a problem in the upstream master branch:

________________ ERROR collecting tests/func/test_s3.py  ________________
ImportError while importing test module '/.../dvc/tests/func/test_s3.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/func/test_s3.py:3: in <module>
    from moto import mock_s3
E   ModuleNotFoundError: No module named 'moto'

UPDATE: Nevermind, I guess that's only happening on my local env. I wonder why. (I did run pip install -e .)

@efiop
Copy link
Contributor

efiop commented Jul 19, 2019

@jorgeorpinel Try pip install git+https://github.com/efiop/moto.git@move-env-mocking, This is a temporary moto version that we are using. Sorry for the inconvenience, I'll add a fixup ASAP.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jul 19, 2019

Np I'm just glad the CI builds pass )

@@ -23,7 +23,7 @@ def run(self):


def add_parser(subparsers, parent_parser):
UPDATE_HELP = "Update dependencies and reproduce specified DVC-files."
UPDATE_HELP = "Update data artifacts imported from other DVC repositories."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this change is due to iterative/dvc.org#490 (comment). Feel free to resolve this comment after reading.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit bd13d6f into iterative:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants