#224 simplify maven setup #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redcatbear
requested changes
Feb 5, 2019
| @@ -429,6 +472,25 @@ | |||
| <ignore></ignore> | |||
| </action> | |||
| </pluginExecution> | |||
| <pluginExecution> | |||
| <pluginExecutionFilter> | |||
| <groupId> | |||
There was a problem hiding this comment.
Please correct (unify) XML formatting.
There was a problem hiding this comment.
<groupId>org.codehaus.mojo</groupId> and so on.
There was a problem hiding this comment.
OK. Can you please provide the XML formatter settings so that we can document this?
We can format the xml files later.
…own" This fixes build error in Eclipse. Once there is code in this module it can be added again.
Codecov Report
@@ Coverage Diff @@
## develop #225 +/- ##
==========================================
Coverage 78.51% 78.51%
Complexity 849 849
==========================================
Files 113 113
Lines 3021 3021
Branches 243 243
==========================================
Hits 2372 2372
Misses 590 590
Partials 59 59Continue to review full report at Codecov.
|
redcatbear
approved these changes
Feb 24, 2019
| @@ -429,6 +472,25 @@ | |||
| <ignore></ignore> | |||
| </action> | |||
| </pluginExecution> | |||
| <pluginExecution> | |||
| <pluginExecutionFilter> | |||
| <groupId> | |||
There was a problem hiding this comment.
<groupId>org.codehaus.mojo</groupId> and so on.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.