-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#306 Required coverage in tag importer #307
Merged
kaklakariada
merged 23 commits into
develop
from
feature/#306-required-coverage-tag-importer
Jan 31, 2022
Merged
#306 Required coverage in tag importer #307
kaklakariada
merged 23 commits into
develop
from
feature/#306-required-coverage-tag-importer
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omit test resources from tracing
Warning: ***************************************************************** Warning: * Your build is requesting parallel execution, but project * Warning: * contains the following plugin(s) that have goals not marked * Warning: * as @threadsafe to support parallel building. * Warning: * While this /may/ work fine, please look for plugin updates * Warning: * and/or request plugins be made thread-safe. * Warning: * If reporting an issue, report it against the plugin in * Warning: * question, not against maven-core * Warning: ***************************************************************** Warning: The following plugins are not marked @threadsafe in OpenFastTrace API: Warning: org.codehaus.mojo:license-maven-plugin:2.0.0 Warning: Enable debug to see more precisely which goals are not marked @threadsafe. Warning: *****************************************************************
We will upgrade with #310
redcatbear
requested changes
Jan 27, 2022
api/src/main/java/org/itsallcode/openfasttrace/api/core/LinkedSpecificationItem.java
Outdated
Show resolved
Hide resolved
importer/tag/src/main/java/org/itsallcode/openfasttrace/importer/tag/LineReader.java
Outdated
Show resolved
Hide resolved
importer/tag/src/main/java/org/itsallcode/openfasttrace/importer/tag/LineReader.java
Outdated
Show resolved
Hide resolved
...ag/src/main/java/org/itsallcode/openfasttrace/importer/tag/LongTagImportingLineConsumer.java
Show resolved
Hide resolved
importer/tag/src/main/java/org/itsallcode/openfasttrace/importer/tag/RegexLineConsumer.java
Outdated
Show resolved
Hide resolved
importer/tag/src/test/java/org/itsallcode/openfasttrace/importer/tag/TestTagImporter.java
Show resolved
Hide resolved
importer/tag/src/test/java/org/itsallcode/openfasttrace/importer/tag/TestTagImporter.java
Show resolved
Hide resolved
Co-authored-by: Sebastian Bär <[email protected]>
Co-authored-by: Sebastian Bär <[email protected]>
…red-coverage-tag-importer
redcatbear
requested changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change in spec.
...ag/src/main/java/org/itsallcode/openfasttrace/importer/tag/LongTagImportingLineConsumer.java
Show resolved
Hide resolved
Co-authored-by: Sebastian Bär <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
redcatbear
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306