Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading Tags from Gherkin feature files #426

Conversation

sophokles73
Copy link
Contributor

@sophokles73 sophokles73 commented Aug 6, 2024

Added "feature" to the list of supported file extensions so that
the standard Tag importer can now extract Tags from comments in
"feature" files as used by Gherkin.

This addresses #425

Closes #425

Added "feature" to the list of supported file extensions so that
the standard Tag importer can now extract Tags from comments in
"feature" files as used by Gherkin.
Copy link
Contributor

@kaklakariada kaklakariada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please create an entry in the latest changelog file. Maybe you need to create a new one for the upcoming version.

@sophokles73
Copy link
Contributor Author

Looks good. Please create an entry in the latest changelog file. Maybe you need to create a new one for the upcoming version.

Are you referring to this file? If so, then IMHO you will need to fill in the gaps first for versions (3.6.0,4.0.2]. Or do you want to me to simply add the change to the Unreleased section?

@sophokles73
Copy link
Contributor Author

Or do you mean creating a new file for version 4.1.0 in this folder?

@kaklakariada
Copy link
Contributor

Good point! CHANGELOG.md is deprecated. I created #427 to migrate its content and remove it.

Please increment the version and add the changelog as described in the developer guide (no need to create a new PR).

Once the PR is merged to main, the build should automatically create a release.

@sophokles73
Copy link
Contributor Author

The broken links checker seems to complain about the not yet existing artifacts which are to be created by the release workflow. Catch 22? ;-)

@kaklakariada kaklakariada merged commit ed8463c into itsallcode:main Aug 7, 2024
9 of 10 checks passed
@sophokles73
Copy link
Contributor Author

@kaklakariada it seems that the automatic release did not work for this PR ...

@kaklakariada
Copy link
Contributor

Argh. I mixed up the release process with our process at work. Here we need to trigger the release workflow manually. And we should have entered the release date in the changelog file.

I will do the release on the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for reading Tags from Gherkin feature files
2 participants