Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to macOS #216

Merged
merged 13 commits into from
Sep 26, 2021
Merged

Adapt to macOS #216

merged 13 commits into from
Sep 26, 2021

Conversation

kaklakariada
Copy link
Contributor

@kaklakariada kaklakariada commented Sep 25, 2021

Adapt to macOS

  • Build app bundle with jpackage
  • Enable system menu bar
  • Add About menu item to application menu

Restriction: "About" menu and system menu bar don't work at the same time. This is a known issue: https://stackoverflow.com/questions/49221738/how-to-implement-javafx-macos-app-with-system-menu-bar-and-handle-desktop-events

Possible workaround: https://github.com/0x4a616e/NSMenuFX

@kaklakariada kaklakariada changed the title Adapt-to-macos Adapt to macOS Sep 25, 2021
@kaklakariada kaklakariada self-assigned this Sep 25, 2021
@kaklakariada kaklakariada added the enhancement New feature or request label Sep 25, 2021
@kaklakariada kaklakariada added this to the Version 1.8.0 milestone Sep 25, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@kaklakariada kaklakariada merged commit c28a1c3 into develop Sep 26, 2021
@kaklakariada kaklakariada deleted the adapt-to-macos branch September 26, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant