Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume spec.vault.auth.kubernetes.secretRef is what is being … #65

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

huguesalary
Copy link
Contributor

…used to authenticate with Vault

Fixes #64

What this PR does / why we need it:

This PR fixes a nil.pointer panic occurring in the Vault store when trying to display an error message

Which issue this PR fixes : fixes #64

Other notes for your reviewer:

Release note:

- Fix nil pointer panic in Vault

Copy link
Collaborator

@mcavoyk mcavoyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcavoyk mcavoyk merged commit 9aacd66 into itscontained:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret-manager panic - vault
2 participants