Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests and cleanup build #67

Merged
merged 6 commits into from
Oct 17, 2020
Merged

Fix e2e tests and cleanup build #67

merged 6 commits into from
Oct 17, 2020

Conversation

mcavoyk
Copy link
Collaborator

@mcavoyk mcavoyk commented Oct 17, 2020

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Other notes for your reviewer:

Release note:

 Change base docker image from `gcr.io/distroless/static` to `alpine:3.12`

@huguesalary
Copy link
Contributor

I'm curious what made you move away from the distroless docker image? I for one really like when container images are this minimal

@mcavoyk
Copy link
Collaborator Author

mcavoyk commented Oct 17, 2020

I'm curious what made you move away from the distroless docker image? I for one really like when container images are this minimal

I prefer minimal images as well, originally used gcr.io/distroless/static as it was Kubebuilder default, but its made with Bazel which I am unfamiliar with and is still working on its multiarch support (GoogleContainerTools/distroless#377).

When ephemeral containers is more widely available, this should be able to move to scratch with just certs added, but until then it can be tricky to debug scratch or gcr.io/distroless/static as there is no shell available.

In terms of size, Alpine is only ~5.6MB over distroless ~1.8MB, not particularly significant compared to debugging utility in my opinion.

@huguesalary
Copy link
Contributor

then it can be tricky to debug scratch or gcr.io/distroless/static as there is no shell available

Yea I agree; I actually ran into this issue earlier today trying to debug some stuff. I though about making a feature request for a special debug image to be built along side the distroless ones.

@mcavoyk mcavoyk merged commit e7aab1c into master Oct 17, 2020
@mcavoyk mcavoyk deleted the fix/e2e-tests branch October 17, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants