allow custom tmux args, fix #79 #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: blob42 <[email protected]>
Signed-off-by: blob42 <[email protected]>
Signed-off-by: blob42 <[email protected]>
Signed-off-by: blob42 <[email protected]>
Signed-off-by: blob42 <[email protected]>
|
Awesome work, thanks! Only one point from me - would you mind removing pretty print? My goal is to keep smug as lightway as possible, and do not depend on external libraries, if I can avoid it. Otherwise PR looks good to me. |
|
Sure I will update the PR 👍
…On June 16, 2024 6:10:07 PM GMT+02:00, Ivan ***@***.***> wrote:
Awesome work, thanks! Only one point from me - would you mind removing pretty print? My goal is to keep smug as lightway as possible, and do not depend on external libraries, if I can avoid it. Otherwise PR looks good to me.
--
Reply to this email directly or view it on GitHub:
#124 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
Hey @blob42, just checking in on this PR. Nice fatures & fixes, and I'd love to get it merged. No rush, but let me know if you need a hand. I can update it with a removed pretty print package myself :) |
|
@blob42 I wrapped up your PR with removed pretty package. Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smug newcommand-Loption #79