Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(goreleaser): fix asset names #128

Merged
merged 1 commit into from
Oct 12, 2024
Merged

chore(goreleaser): fix asset names #128

merged 1 commit into from
Oct 12, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Oct 11, 2024

Remove quotes and a space from asset names.

Issue to solve

Asset names include quotes and a space.

$ goreleaser release --snapshot
  • skipping announce, publish and validate...
  • loading environment variables
  • getting and validating git state
    • git state                                      commit=f0ea4942e0d73a64f9f10b04eb7b0531f398e441 branch=master current_tag=v0.3.5 previous_tag=v0.3.4 dirty=false
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=v0.3.5-next
  • running before hooks
    • running                                        hook=go mod download
  • ensuring distribution directory
  • setting up metadata
  • writing release metadata
  • loading go mod information
  • build prerequisites
  • building binaries
    • building                                       binary=dist/smug_darwin_arm64/smug
    • building                                       binary=dist/smug_windows_arm64/smug.exe
    • building                                       binary=dist/smug_windows_386/smug.exe
    • building                                       binary=dist/smug_linux_arm64/smug
    • building                                       binary=dist/smug_linux_amd64_v1/smug
    • building                                       binary=dist/smug_linux_386/smug
    • building                                       binary=dist/smug_darwin_amd64_v1/smug
    • building                                       binary=dist/smug_windows_amd64_v1/smug.exe
  • archives
    • creating                                       archive=dist/"smug v0.3.5-next"_Linux_x86_64.tar.gz
    • creating                                       archive=dist/"smug v0.3.5-next"_Darwin_arm64.tar.gz
    • creating                                       archive=dist/"smug v0.3.5-next"_Windows_x86_64.zip
    • creating                                       archive=dist/"smug v0.3.5-next"_Linux_i386.tar.gz
    • creating                                       archive=dist/"smug v0.3.5-next"_Darwin_x86_64.tar.gz
    • creating                                       archive=dist/"smug v0.3.5-next"_Linux_arm64.tar.gz
    • creating                                       archive=dist/"smug v0.3.5-next"_Windows_arm64.zip
    • creating                                       archive=dist/"smug v0.3.5-next"_Windows_i386.zip
  • linux packages
    • creating                                       package=smug format=rpm arch=arm64 file=dist/smug_v0.3.5-next_linux_arm64.rpm
    • creating                                       package=smug format=deb arch=amd64v1 file=dist/smug_v0.3.5-next_linux_amd64.deb
    • creating                                       package=smug format=rpm arch=amd64v1 file=dist/smug_v0.3.5-next_linux_amd64.rpm
    • creating                                       package=smug format=rpm arch=386 file=dist/smug_v0.3.5-next_linux_386.rpm
    • creating                                       package=smug format=deb arch=386 file=dist/smug_v0.3.5-next_linux_386.deb
    • creating                                       package=smug format=deb arch=arm64 file=dist/smug_v0.3.5-next_linux_arm64.deb
  • calculating checksums
  • writing artifacts metadata
  • release succeeded after 6s
  • thanks for using goreleaser!
$ ls dist 
'"smug v0.3.5-next"_Darwin_arm64.tar.gz'    checksums.txt                    smug_v0.3.5-next_linux_386.rpm
'"smug v0.3.5-next"_Darwin_x86_64.tar.gz'   config.yaml                      smug_v0.3.5-next_linux_amd64.deb
'"smug v0.3.5-next"_Linux_arm64.tar.gz'     metadata.json                    smug_v0.3.5-next_linux_amd64.rpm
'"smug v0.3.5-next"_Linux_i386.tar.gz'      smug_darwin_amd64_v1             smug_v0.3.5-next_linux_arm64.deb
'"smug v0.3.5-next"_Linux_x86_64.tar.gz'    smug_darwin_arm64                smug_v0.3.5-next_linux_arm64.rpm
'"smug v0.3.5-next"_Windows_arm64.zip'      smug_linux_386                   smug_windows_386
'"smug v0.3.5-next"_Windows_i386.zip'       smug_linux_amd64_v1              smug_windows_amd64_v1
'"smug v0.3.5-next"_Windows_x86_64.zip'     smug_linux_arm64                 smug_windows_arm64
 artifacts.json                             smug_v0.3.5-next_linux_386.deb

GitHub removes quotes and converts a space into a period.

https://github.com/ivaaaan/smug/releases/tag/v0.3.5

image
$ gh release -R ivaaaan/smug view v0.3.5
v0.3.5
github-actions[bot] released this about 12 hours ago

  ## Changelog                                                                                                        
                                                                                                                      
  • a4a05e8a62410c3cdee726f2f8d4bb894dd6ff26 Feature/allow to group projects dirs issue #89 (#127)                    


Assets
checksums.txt                     1.30 KiB
smug.0.3.5._Darwin_arm64.tar.gz   1.10 MiB
smug.0.3.5._Darwin_x86_64.tar.gz  1.16 MiB
smug.0.3.5._Linux_arm64.tar.gz    1.07 MiB
smug.0.3.5._Linux_i386.tar.gz     1.10 MiB
smug.0.3.5._Linux_x86_64.tar.gz   1.15 MiB
smug.0.3.5._Windows_arm64.zip     1.10 MiB
smug.0.3.5._Windows_i386.zip      1.16 MiB
smug.0.3.5._Windows_x86_64.zip    1.20 MiB
smug_0.3.5_linux_386.deb          1.10 MiB
smug_0.3.5_linux_386.rpm          1.13 MiB
smug_0.3.5_linux_amd64.deb        1.15 MiB
smug_0.3.5_linux_amd64.rpm        1.19 MiB
smug_0.3.5_linux_arm64.deb        1.08 MiB
smug_0.3.5_linux_arm64.rpm        1.10 MiB

Test

I've confirmed the issue would be solved.

$ goreleaser release --snapshot --clean           
  • skipping announce, publish and validate...
  • cleaning distribution directory
  • loading environment variables
  • getting and validating git state
    • git state                                      commit=f0ea4942e0d73a64f9f10b04eb7b0531f398e441 branch=master current_tag=v0.3.5 previous_tag=v0.3.4 dirty=true
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=v0.3.5-next
  • running before hooks
    • running                                        hook=go mod download
  • ensuring distribution directory
  • setting up metadata
  • writing release metadata
  • loading go mod information
  • build prerequisites
  • building binaries
    • building                                       binary=dist/smug_darwin_arm64/smug
    • building                                       binary=dist/smug_windows_386/smug.exe
    • building                                       binary=dist/smug_darwin_amd64_v1/smug
    • building                                       binary=dist/smug_linux_amd64_v1/smug
    • building                                       binary=dist/smug_windows_amd64_v1/smug.exe
    • building                                       binary=dist/smug_linux_arm64/smug
    • building                                       binary=dist/smug_windows_arm64/smug.exe
    • building                                       binary=dist/smug_linux_386/smug
  • archives
    • creating                                       archive=dist/smug_v0.3.5-next_Windows_arm64.zip
    • creating                                       archive=dist/smug_v0.3.5-next_Darwin_arm64.tar.gz
    • creating                                       archive=dist/smug_v0.3.5-next_Linux_i386.tar.gz
    • creating                                       archive=dist/smug_v0.3.5-next_Windows_i386.zip
    • creating                                       archive=dist/smug_v0.3.5-next_Linux_x86_64.tar.gz
    • creating                                       archive=dist/smug_v0.3.5-next_Linux_arm64.tar.gz
    • creating                                       archive=dist/smug_v0.3.5-next_Darwin_x86_64.tar.gz
    • creating                                       archive=dist/smug_v0.3.5-next_Windows_x86_64.zip
  • linux packages
    • creating                                       package=smug format=deb arch=amd64v1 file=dist/smug_v0.3.5-next_linux_amd64.deb
    • creating                                       package=smug format=deb arch=386 file=dist/smug_v0.3.5-next_linux_386.deb
    • creating                                       package=smug format=rpm arch=386 file=dist/smug_v0.3.5-next_linux_386.rpm
    • creating                                       package=smug format=deb arch=arm64 file=dist/smug_v0.3.5-next_linux_arm64.deb
    • creating                                       package=smug format=rpm arch=amd64v1 file=dist/smug_v0.3.5-next_linux_amd64.rpm
    • creating                                       package=smug format=rpm arch=arm64 file=dist/smug_v0.3.5-next_linux_arm64.rpm
  • calculating checksums
  • writing artifacts metadata
  • release succeeded after 3s
  • thanks for using goreleaser!
$ ls dist 
artifacts.json        smug_linux_amd64_v1                    smug_v0.3.5-next_Windows_arm64.zip   smug_v0.3.5-next_linux_arm64.deb
checksums.txt         smug_linux_arm64                       smug_v0.3.5-next_Windows_i386.zip    smug_v0.3.5-next_linux_arm64.rpm
config.yaml           smug_v0.3.5-next_Darwin_arm64.tar.gz   smug_v0.3.5-next_Windows_x86_64.zip  smug_windows_386
metadata.json         smug_v0.3.5-next_Darwin_x86_64.tar.gz  smug_v0.3.5-next_linux_386.deb       smug_windows_amd64_v1
smug_darwin_amd64_v1  smug_v0.3.5-next_Linux_arm64.tar.gz    smug_v0.3.5-next_linux_386.rpm       smug_windows_arm64
smug_darwin_arm64     smug_v0.3.5-next_Linux_i386.tar.gz     smug_v0.3.5-next_linux_amd64.deb
smug_linux_386        smug_v0.3.5-next_Linux_x86_64.tar.gz   smug_v0.3.5-next_linux_amd64.rpm

Remove quotes and a space from asset names.
@ivaaaan ivaaaan merged commit c823357 into ivaaaan:master Oct 12, 2024
1 check passed
@suzuki-shunsuke suzuki-shunsuke deleted the chore-fix-asset-name branch October 12, 2024 08:37
@ivaaaan
Copy link
Owner

ivaaaan commented Oct 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants