Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #13

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

sidequestlegend
Copy link
Contributor

I had an issue with a bunch of errors like this:

TypeError: Cannot read property 'some' of undefined
                                                                                       
      at Object.exports.install (node_modules/whatwg-url/dist/URL.js:84:20)

jestjs/jest#10489 (comment) - shows that its an issue with jsdom 16.2.2. I tested by forcing the next newer version 16.3.0 which fixed the problem, so I propose that this dependency be updated.

I had an issue with a bunch of errors like this: 

```
TypeError: Cannot read property 'some' of undefined
                                                                                       
      at Object.exports.install (node_modules/whatwg-url/dist/URL.js:84:20)
```

jestjs/jest#10489 (comment) - shows that its an issue with jsdom 16.2.2. I tested by forcing the next newer version 16.3.0 which fixed the problem, so I propose that this dependency be updated.
@ivanblazevic
Copy link
Owner

Sounds good, thnx for fixing it!

@ivanblazevic ivanblazevic merged commit bcf4334 into ivanblazevic:master Nov 20, 2020
@ivanblazevic
Copy link
Owner

@sidequestlegend your fix is included in new release https://www.npmjs.com/package/ngx-unused-css/v/2.2.0

@sidequestlegend
Copy link
Contributor Author

thank you! much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants