Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client] fix negative acknowledgement by messageid #5

Closed
wants to merge 2 commits into from

Conversation

izumo27
Copy link
Owner

@izumo27 izumo27 commented Jul 21, 2024

Motivation

When adding to unAckedMessageTracker, batch messages are converted.

if the messageId is a BatchMessageIdImpl, the messageId will not be removed from the UnAckedMessageTracker.
https://github.com/apache/pulsar/blob/v3.3.0/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L814

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@izumo27 izumo27 force-pushed the fix_nack_by_messageid branch 2 times, most recently from cda846b to 8d23809 Compare July 21, 2024 16:07
@izumo27 izumo27 force-pushed the fix_nack_by_messageid branch from cd78982 to 8ad4d2e Compare July 22, 2024 05:07
@izumo27 izumo27 closed this Aug 1, 2024
@izumo27 izumo27 deleted the fix_nack_by_messageid branch August 13, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant