Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring upgrading lwjgl3 v.3 #824

Merged
merged 2 commits into from
Feb 26, 2018

Conversation

JavaSaBr
Copy link
Contributor

A compacted version of this PR:
#790

@JavaSaBr
Copy link
Contributor Author

@Nehon attempt #3 :)

@JavaSaBr
Copy link
Contributor Author

@Nehon anything else?

@AlrikG
Copy link
Contributor

AlrikG commented Feb 26, 2018

Hi JavaSaBr,
Sorry if you've already answered this question somewhere, but why did you remove the public access modifier from the GL class's statics and methods?

@JavaSaBr
Copy link
Contributor Author

Hi, because the public is default access for interfaces.

@Nehon Nehon merged commit 555a348 into jMonkeyEngine:master Feb 26, 2018
@AlrikG
Copy link
Contributor

AlrikG commented Feb 26, 2018

Ok thanks :) I overlooked that. But this also means that you can remove the static and final modifiers from constants. Am I right? => https://docs.oracle.com/javase/tutorial/java/IandI/interfaceDef.html

@pspeed42
Copy link
Contributor

Did you read back where we had him put it back because we prefer it the verbose way in this case?
a) it's easier to cut-paste
b) it's easier to grep/search through code
c) it avoids conversations like these where you have to point to the spec to prove that you can do it.

@AlrikG
Copy link
Contributor

AlrikG commented Feb 27, 2018

No sorry I only looked into the changes instead of the PR #790

@stephengold stephengold added this to the v3.2.2 milestone Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants