Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xorBlock for RISC-V architecture #13

Open
nmeum opened this issue Jan 8, 2022 · 1 comment · May be fixed by #14
Open

Add xorBlock for RISC-V architecture #13

nmeum opened this issue Jan 8, 2022 · 1 comment · May be fixed by #14

Comments

@nmeum
Copy link

nmeum commented Jan 8, 2022

The xorBlock function does not have support for RISC-V and thus software depending on crypto e.g. gocryptfs does not compile on RISC-V:

// +build amd64 arm64 ppc64 ppc64le s390x mips64 mips64le

Unfortunately, unaligned loads (which are used by the present xorBlock implementation) are implementation-defined behavior on RISC-V and should thus not be relied on (Section 2.6, "Load and Store Instructions" in the unprivileged ISA specification):

Loads and stores where the effective address is not naturally aligned to the referenced datatype (i.e., on a four-byte boundary for 32-bit accesses, and a two-byte boundary for 16-bit accesses) have behavior dependent on the EEI.

Maybe it makes sense to add a generic fallback implementation of the xorBlock function which does not make use of unaligned loads?

Alpine Linux downstream issue where this was originally reported: https://gitlab.alpinelinux.org/alpine/aports/-/issues/12793

@paralin
Copy link

paralin commented Jun 25, 2022

rfjakob/gocryptfs#666

paralin added a commit to paralin/gocryptfs that referenced this issue Jun 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: rfjakob#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jun 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/gocryptfs that referenced this issue Jun 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: rfjakob#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jun 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jun 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jun 27, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jun 27, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 11, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/gocryptfs that referenced this issue Jul 14, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: rfjakob#666

Upstream PR: jacobsa/crypto#13

Unaddressed on jacobsa/crypto:

jacobsa/crypto#14 (comment)

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 14, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 15, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 15, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 19, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 24, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 24, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 25, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Jul 26, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Aug 2, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to skiffos/buildroot that referenced this issue Aug 2, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this issue Aug 2, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Thomas Petazzoni <[email protected]>
woodsts pushed a commit to woodsts/buildroot that referenced this issue Sep 14, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Fixes:
- http://autobuild.buildroot.net/results/caa60874781c4077273884eb37281cc9e02ef9ac/
- rfjakob/gocryptfs#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Thomas Petazzoni <[email protected]>
(cherry picked from commit 33c1ad4)
Signed-off-by: Peter Korsgaard <[email protected]>
paralin added a commit to paralin/gocryptfs that referenced this issue Dec 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: rfjakob#666

Upstream PR: jacobsa/crypto#13

Unaddressed on jacobsa/crypto:

jacobsa/crypto#14 (comment)

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/gocryptfs that referenced this issue Dec 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: rfjakob#666

Upstream PR: jacobsa/crypto#13

Unaddressed on jacobsa/crypto:

jacobsa/crypto#14 (comment)

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/gocryptfs that referenced this issue Dec 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: rfjakob#666

Upstream PR: jacobsa/crypto#13

Unaddressed on jacobsa/crypto:

jacobsa/crypto#14 (comment)

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/gocryptfs that referenced this issue Dec 8, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: rfjakob#666

Upstream PR: jacobsa/crypto#13

Signed-off-by: Christian Stewart <[email protected]>
rfjakob pushed a commit to rfjakob/gocryptfs that referenced this issue Dec 21, 2022
Replace dependency jacobsa/crypto with a fork with support for riscv64.

Issue: #666

Upstream PR: jacobsa/crypto#13

Unaddressed on jacobsa/crypto:

jacobsa/crypto#14 (comment)

Signed-off-by: Christian Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants