Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add option to enable gen128Bit for tracer #193

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

pengsrc
Copy link
Contributor

@pengsrc pengsrc commented Aug 24, 2017

Signed-off-by: Jingwen Peng [email protected]

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2017

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.413% when pulling 1fd68ba on pengsrc:master into 1f15fec on uber:master.

@black-adder
Copy link
Contributor

thanks for this, do you mind adding a small test to cover the new option?

@pengsrc
Copy link
Contributor Author

pengsrc commented Aug 24, 2017

No problem, I'll add it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 85.532% when pulling 3ccac6f on pengsrc:master into 1f15fec on uber:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.71% when pulling 63ce24d on pengsrc:master into 1f15fec on uber:master.

@pengsrc
Copy link
Contributor Author

pengsrc commented Aug 24, 2017

@black-adder Hi, the related tests have been added, please check that.

Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just be careful if you have other services using different languages (java) which don't have this feature since those clients will lose the top 64 bits of the trace id when they report.

@black-adder black-adder merged commit 7c8937d into jaegertracing:master Aug 25, 2017
@pengsrc
Copy link
Contributor Author

pengsrc commented Aug 25, 2017

Thanks for this nice advice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants