Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Use value receiver for config.NewTracer() #283

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

yurishkuro
Copy link
Member

The new function is defined on a pointer received, making it harder to use, e.g. below doesn't work even when using the &:

	tracer, closer, err := &jaeger.Configuration{
		ServiceName: *name,
		Sampler:     &jaeger.SamplerConfig{Type: "const", Param: 1},
	}.NewTracer()

Also correct the naming of examples functions to match godoc guidelines, and fix README examples.

@yurishkuro yurishkuro requested a review from jpkrohling April 8, 2018 18:26
@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          55       55           
  Lines        2972     2972           
=======================================
  Hits         2564     2564           
  Misses        287      287           
  Partials      121      121
Impacted Files Coverage Δ
config/config.go 92.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623e968...6d0b298. Read the comment docs.

@yurishkuro yurishkuro merged commit d96234c into master Apr 9, 2018
@yurishkuro yurishkuro deleted the cleanup-cfg-newtracer branch May 5, 2021 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants