Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Remove tchannel tests from crossdock #294

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Remove tchannel tests from crossdock #294

merged 1 commit into from
Apr 24, 2018

Conversation

yurishkuro
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 24, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7942ae9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #294   +/-   ##
=========================================
  Coverage          ?   86.62%           
=========================================
  Files             ?       55           
  Lines             ?     3006           
  Branches          ?        0           
=========================================
  Hits              ?     2604           
  Misses            ?      282           
  Partials          ?      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7942ae9...9f8ccad. Read the comment docs.

isaachier
isaachier reviewed Apr 24, 2018
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated
@@ -0,0 +1,28 @@
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

@yurishkuro yurishkuro force-pushed the remove-tchannel-tests-from-crossdock branch from 4dd5f65 to 9f8ccad Compare April 24, 2018 19:07
@yurishkuro yurishkuro merged commit 6f4ee9d into master Apr 24, 2018
yurishkuro added a commit that referenced this pull request Apr 30, 2018
@yurishkuro
Prepare release 2.14 (#305)
b043381 
- Support throttling for debug traces (#274) <Isaac Hier>
- Remove dependency on Apache Thrift (#303) <Yuri Shkuro>
- Remove dependency on tchannel  (#295) (#294) <Yuri Shkuro>
- Test with Go 1.9 (#298) <Yuri Shkuro>

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro deleted the remove-tchannel-tests-from-crossdock branch May 5, 2021 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isaachier isaachier isaachier left review comments

@black-adder black-adder black-adder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurishkuro @black-adder @isaachier