This repository has been archived by the owner on May 23, 2024. It is now read-only.
zipkin: make extractor also accept "true" for the x-b3-sampled header #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Bogatu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 87.19% 87.19%
=======================================
Files 54 54
Lines 2999 2999
=======================================
Hits 2615 2615
Misses 272 272
Partials 112 112
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #355.
Short description of the changes
Make the zipkin propagator returned by
zipkin.NewZipkinB3HTTPHeaderPropagator()acceptx-b3-sampledwith a value of"true", not only"1"for interoperability with other frameworks that send the value in this format.Also add relevant tests.