This repository has been archived by the owner on May 23, 2024. It is now read-only.
Update zipkin propagation logic to support 128bit traceIDs #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Reid <[email protected]>
yurishkuro
reviewed
Feb 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 87.22% 87.29% +0.06%
==========================================
Files 54 54
Lines 3006 3006
==========================================
+ Hits 2622 2624 +2
+ Misses 272 271 -1
+ Partials 112 111 -1
Continue to review full report at Codecov.
|
Signed-off-by: Douglas Reid <[email protected]>
|
@yurishkuro Sure. Added some tests. Please let me know if more is needed. |
|
oh, did you miss the sign-off on the last commit? |
golangcibot
reviewed
Feb 14, 2019
zipkin/propagation_test.go
Outdated
| assert.EqualValues(t, jaeger.TraceID{High: high, Low: low}, spanCtx.TraceID()) | ||
|
|
||
| hdr := opentracing.TextMapCarrier{} | ||
| propagator.Inject(spanCtx, hdr) |
There was a problem hiding this comment.
Error return value of propagator.Inject is not checked (from errcheck)
Signed-off-by: Douglas Reid <[email protected]>
douglas-reid
force-pushed
the
zipkin-128bits
branch
from
5ea0b01 to
527f301
Compare
|
@yurishkuro probably. updated commit and force pushed. |
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Douglas Reid [email protected]
Which problem is this PR solving?
Short description of the changes